$DEVICE naming changes #1356
Merged
$DEVICE naming changes #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your change looks OK to me. |
|
Like I wrote: SYSTEM has nothing to do with DEVICE. The only reason I introduce SYSTEM was to distinguish which final image to build because of different bootloader has to be used. All other pieces are the same. That's why it is not needed to build multiple projects just because of one (or few) different package. |
|
OK I understand the difference now. Thanks. |
|
@lrusak can you rebase this pls. |
|
rebased. |
|
bueller? |
chewitt
approved these changes
Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First we want to be able to build the base project by itself.The $DEVICE should be an overlay of the base project, not it's own.The naming should use $DEVICE.$ARCH not $PROJECT.$DEVICE.$ARCH. This makes it so we don't have to change any backend or updated things.
ping @codesnake @kszaq @kivutar and whoever else may use the $DEVICE call that this may change the way their build works.